Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic editor for text notes (with fixed toolbar) #571

Merged
merged 26 commits into from
Nov 9, 2024

Conversation

eliandoran
Copy link
Contributor

@eliandoran eliandoran commented Nov 9, 2024

Added an option in Text Notes -> Formatting toolbar to allow switching between a floating editor (the current implementation) and a fixed toolbar.

image

Floating editor:

image

Fixed editor:

image

@eliandoran eliandoran marked this pull request as ready for review November 9, 2024 20:33
@eliandoran eliandoran merged commit 81310d3 into develop Nov 9, 2024
1 check passed
@meichthys
Copy link
Contributor

Very nice!

@Br0kenSilos
Copy link

I like it. :-)

@Praetorian1410
Copy link

Thank you so much - exactly what I was after!

@ups7
Copy link

ups7 commented Nov 11, 2024

I really wanted the fixed toolbar, thank you!

@brokoler
Copy link

This feature is great, thanks a lot!

There is one important icon missing, that I expected would be added.
The "Find and Replace" icon is missing in the fixed toolbar in TriliumNext.
In CKEditor it's part of the toolbar and was also part of Trilum: zadam/trilium#679

276420927-686c56e2-bf5d-4e75-ad6f-9598e442f38a

Not sure if I'm missing something, but it would be great if the "Find and Replace" icon could be added as well to the fixed toolbar.

@eliandoran
Copy link
Contributor Author

@brokoler , thanks for the report. Added it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants