Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions based testing for TriBITS (#363) #393

Merged
merged 33 commits into from
Jul 21, 2021
Merged

GitHub Actions based testing for TriBITS (#363) #393

merged 33 commits into from
Jul 21, 2021

Conversation

bartlettroscoe
Copy link
Member

@bartlettroscoe bartlettroscoe commented Jul 20, 2021 •
edited
Loading

Implements beginning of automated testing of TriBITS using GitHub Actions as per #363. This is a follow-on from the branch in PR #389 with a renamed branch and rebased on 'master'.

Tasks:

  • Create file tribits_cmake-3.21.0_makefiles_python-3.8_g++-9_tweaks.cmake disables for cmake-3.21.0 GHA build to disable tests that fail with CMake 3.20.
  • Add install of docutils to github actions job and enable build_docs test.
  • Add new triggers workflow_dispatch and schedule.
  • Determine what branch the GitHub Action jobs was invoked on and send jobs to CDash to different CDash groups based on the event trigger: PRs and manual triggers to 'Experimental', pushes to 'master' to 'Continuous', cron jobs to 'Nightly' (see GITHUB_EVENT_NAME).
  • Merge this PR.

marcinwrobel1986 and others added 29 commits July 20, 2021 11:39
@marcinwrobel1986 @bartlettroscoe
first try with CI (TriBITSPub#363)
c29c737
@marcinwrobel1986 @bartlettroscoe
added no fortran option (TriBITSPub#363)
1f4eefc
@marcinwrobel1986 @bartlettroscoe
run job only when push on master branch (TriBITSPub#363)
0a820c9
@marcinwrobel1986 @bartlettroscoe
attempt to try different variants (TriBITSPub#363)
516e4b8
@marcinwrobel1986 @bartlettroscoe
added version checking (TriBITSPub#363)
abb9d26
@marcinwrobel1986 @bartlettroscoe
try to get specific versions (TriBITSPub#363)
6a583e3
@marcinwrobel1986 @bartlettroscoe
separate removing and installation (TriBITSPub#363)
8bd47f0
@marcinwrobel1986 @bartlettroscoe
checks for testing purposes (TriBITSPub#363)
2828e15
@marcinwrobel1986 @bartlettroscoe
removed checks (TriBITSPub#363)
28f09d1
@marcinwrobel1986 @bartlettroscoe
created aliases (TriBITSPub#363)
ea1bcc1
@marcinwrobel1986 @bartlettroscoe
check if aliases work (TriBITSPub#363)
53b85c6
@marcinwrobel1986 @bartlettroscoe
trying other way (TriBITSPub#363)
b5a7235
@marcinwrobel1986 @bartlettroscoe
fixed if (TriBITSPub#363)
66eba6b
@marcinwrobel1986 @bartlettroscoe
fixed if (TriBITSPub#363)
13738fb
@marcinwrobel1986 @bartlettroscoe
check for aliases (TriBITSPub#363)
d384806
@marcinwrobel1986 @bartlettroscoe
try alternatives (TriBITSPub#363)
d42fa0e
@marcinwrobel1986 @bartlettroscoe
try alternatives (TriBITSPub#363)
390645a
@marcinwrobel1986 @bartlettroscoe
try alternatives (TriBITSPub#363)
cf1fb0d
@marcinwrobel1986 @bartlettroscoe
fix memory problem (TriBITSPub#363)
c9d7fd2 
- fix if
@marcinwrobel1986 @bartlettroscoe
removed unnecessary options (TriBITSPub#363)
c43ae1c
@marcinwrobel1986 @bartlettroscoe
changing order of the tests (TriBITSPub#363)
643451e
@bartlettroscoe
No more hello_world.yml (TriBITSPub#363)
0bb8b63 
We have a real GitHub Actions now.
@bartlettroscoe
Add 'generator' option (not used yet) (TriBITSPub#363)
49dd52f
@bartlettroscoe
Add GitHub Actions-specific driver (TriBITSPub#363)
44eea91 
Any non-trivial logic in a script, we can develop and test it locally.  This
is a win-win-win over putting all of this logic in the GitHub Action YAML
file.

This should have the proper site name, build name, use the correct generator,
and enable or disable Fortran correctly.
@bartlettroscoe
Change max-parallel from 1 to 4 (TriBITSPub#363)
cf44d9b 
Why not let the jobs run all at the same time?
@bartlettroscoe
Set 'fail-fast' to false (TriBITSPub#363)
4b3f451
@bartlettroscoe
Don't test build of docs for now (TriBITSPub#363)
ad91648 
We will need to install docutils if we want to test the generation of
documentation.
@bartlettroscoe
Rearrange options in matrix to match order in CTEST_BUILD_NAME (TriBI…
46fb97f 
…TSPub#363)

Makes easier to read.
@bartlettroscoe
Make all builds use makefiles for now (TriBITSPub#363)
533268b 
I suspect that some of the tests are not robust enough to work with Ninja as
the outer generator.  There are some tests that will use Ninja for the inner
configure to make sure that it works.

Making the entire TriBITS test suite pass using Ninja as the generator in
place of Makefiles would be a lot of work.  Or, we could conditionally enable
many of the tests that depend Unix Makefile logic.
@bartlettroscoe bartlettroscoe self-assigned this Jul 20, 2021
This was referenced Jul 20, 2021
Closed
Closed
@bartlettroscoe
Switch from cmake 3.17.0 to cmake 3.17.5 (TriBITSPub#363)
1ea9945 
CMake 3.17.5 is the latest patch release for the CMake 3.17.z series.  We
should be using the latest patch release for testing with CMake 3.17 in
general.
@bartlettroscoe
Disable failing cmake-3.21.0 tests for now (TriBITSPub#363)
4fdfceb 
We can't have these tests failing in our deployed testing build.  We have PR
@bartlettroscoe bartlettroscoe force-pushed the 363-github-actions-tests branch from 6665193 to a076ba8 Compare July 21, 2021 01:04
@bartlettroscoe
Install dependencies for and test build of docutils documentation (Tr…
6ae2723 
…iBITSPub#363)

NOTE: I am installing sphinx which also installs docustils rst2html.py tool.
I am installing sphinx and sphinx-rtd-theme in anticipation of testing the
generation of the sphinx-based build of the documentation currently being
worked in TriBITSPub#386.
@bartlettroscoe bartlettroscoe force-pushed the 363-github-actions-tests branch from a076ba8 to 6ae2723 Compare July 21, 2021 01:08
@bartlettroscoe
Add manual and cron triggers, set proper CDash groups (TriBITSPub#363)
56b5036 
I can't fully test this until this gets merged to 'master' but this should be
close.
@bartlettroscoe bartlettroscoe force-pushed the 363-github-actions-tests branch from 3fb3eed to 56b5036 Compare July 21, 2021 01:42
@bartlettroscoe bartlettroscoe merged commit 3937fda into TriBITSPub:master Jul 21, 2021
@bartlettroscoe bartlettroscoe mentioned this pull request Jul 21, 2021
Closed
16 tasks
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this pull request Sep 4, 2021
@bartlettroscoe
Merge branch 'tribits_github_snapshot' into tribits-snapshot-2021-09-03
3c77011 
Brings in numerous refactorings to TriBITS over the last 3 months, but there
should be no breaks in backward compatibility.  Almost every file in TriBITS
is changed due to the lower-casing of command, macro and function names in PR
TriBITSPub/TriBITS#379.  But the main driver for this snapshot is to bring in
the change in PR TriBITSPub/TriBITS#413 that should make it so that Kokkos
INTERFACE_COMPILE_OPTIONS get propagated to downstream targets in TriBITS and
therefore to external customers through installed <Package>Config.cmake files
and IMPORTED targets.  I should have done several snapshots in the last few
months and not done a big snapshot like this (but I have been testing with
Trilinos locally along the way).

Overall, this merge brings in changes from a bunch of TriBITS PRs including
(from most recent):

* TriBITSPub/TriBITS#413: Change internal TriBITS target_link_libraries() to
  PUBLIC (TriBITSPub/TriBITS#299) component: core type: enhancement

* TriBITSPub/TriBITS#410: Upgrade from cmake 3.21.0 to 3.21.2
  (TriBITSPub/TriBITS#363, TriBITSPub/TriBITS#394)

* TriBITSPub/TriBITS#394: DO NOT MERGE: Show TriBITS test failures with CMake
  3.21.0 that don't occur with CMake 3.17.5 (TriBITSPub/TriBITS#363)

* TriBITSPub/TriBITS#409: Add getTestDictStatusField() to handle empty
  'status' field (SESW-383) component: ci_support type: enhancement

* TriBITSPub/TriBITS#408: Deal with spaces in CDash url parts (SESW-383)
  component: ci_support type: enhancement

* TriBITSPub/TriBITS#403: Spelling fixes

* TriBITSPub/TriBITS#407: Move tribits_get_build_url_and_write_to_file() to
  stand-alone module (TriBITSPub/TriBITS#154) component: ctest_driver type:
  enhancement

* TriBITSPub/TriBITS#388: Fixing typos (TriBITSPub/TriBITS#377)

* TriBITSPub/TriBITS#406: Fix tribits_ctest_driver() package-by-package mode
  for CMake 3.19+ (TriBITSPub/TriBITS#363, TriBITSPub/TriBITS#394) component:
  ctest_driver type: bug

* TriBITSPub/TriBITS#401: Improve GitHub Actions and CDash integration
  (TriBITSPub/TriBITS#154) type: enhancement

* TriBITSPub/TriBITS#366: CI: draft action yaml

* TriBITSPub/TriBITS#402: Revert some incorrect uppercase->lowercase changes

* TriBITSPub/TriBITS#387: Build and deploy TriBITS documentation with Sphinx
  (TriBITSPub/TriBITS#386) component: documentation type: enhancement

* TriBITSPub/TriBITS#398: Deal with pr null in not preprending build name
  (TriBITSPub/TriBITS#363) type: bug

* TriBITSPub/TriBITS#396: Send PR results to 'Pull Request' CDash group and
  add PR ID to build names (TriBITSPub/TriBITS#363) type: enhancement

* TriBITSPub/TriBITS#397: Print the ninja path and version
  (TriBITSPub/TriBITS#363)

* TriBITSPub/TriBITS#393: GitHub Actions based testing for TriBITS
  (TriBITSPub/TriBITS#363) type: enhancement

* TriBITSPub/TriBITS#389: TriBITS CI testing with GitHub Actions
  (TriBITSPub/TriBITS#363) type: enhancement

* TriBITSPub/TriBITS#392: Fix broken tests for non-Fortran and CMake 3.21
  builds (TriBITSPub/TriBITS#363) component: core

* TriBITSPub/TriBITS#391: Fix up build_docs.sh for Sphinx doc generation
  (TriBITSPub/TriBITS#386) component: documentation type: enhancement

* TriBITSPub/TriBITS#390: Add test for doc generation and fix usage of Python3
  component: documentation type: bug

* TriBITSPub/TriBITS#385: Replace last few references to
  TribitsDevelopersGuide.html (TriBITSPub/TriBITS#381) component:
  documentation type: enhancement

* TriBITSPub/TriBITS#384: Split TribitsDevelopersGuide.* into
  TribitsUsersGuide.* and TribitsMaintainersGuide.* (TriBITSPub/TriBITS#381)
  component: documentation type: enhancement

* TriBITSPub/TriBITS#383: Remove endfunction(<string>) and endmacro(<string>)
  (TriBITSPub/TriBITS#274, TriBITSPub/TriBITS#382) component: common_tpls
  type: bug

* TriBITSPub/TriBITS#380: More package-arch data-structure documentation
  updates (TriBITSPub/TriBITS#63) component: documentation type: enhancement

* TriBITSPub/TriBITS#379: Convert TriBITS to lower-case CMake command, macro,
  and function names (TriBITSPub/TriBITS#274)

The following files were conflicting where I went with what is on the Trilinos
'develop' branch:

* cmake/tribits/common_tpls/FindTPLBLAS.cmake
* cmake/tribits/common_tpls/FindTPLLAPACK.cmake
* cmake/tribits/common_tpls/FindTPLNetcdf.cmake

(It looks like the above changes never made it back into TriBITS proper.  The
conflicts were due to the case changes in cmake command calls in these files
due to TriBITSPub/TriBITS#379.)

There was also a conflict in the file:

* cmake/tribits/core/installation/TribitsProjectConfigTemplate.cmake.in

I looked at that one carefully and I think that may have been due to fixes on
both sides and then the case changes from TriBITSPub/TriBITS#379.
@bartlettroscoe bartlettroscoe mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bartlettroscoe bartlettroscoe

Labels
type: enhancement
Projects
TriBITS Refactor
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlettroscoe @marcinwrobel1986