-
-
Notifications
You must be signed in to change notification settings - Fork 177
fix: migrate build tools to tsdown #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
42afdf7
refactor(core): use tsdown instead of vite lib mode
alvarosabu b80130b
chore(deps): add tsdown dependency and update package configurations
alvarosabu c61219f
chore(tsdown): update tsdown configuration and package.json references
alvarosabu b951925
chore(tsdown): add tsdown configuration file and update build scripts…
alvarosabu 1fe5196
chore(package): remove unused core entry and update main field in pac…
alvarosabu f7ed059
chore(deps): update @vitejs/plugin-vue version and add new dependenci…
alvarosabu f4524a8
chore(pnpm): remove tsdown dependency from pnpm-lock.yaml
alvarosabu 1b138e1
Merge branch 'main' into chore/tsdown-build
alvarosabu 4218b7b
chore: add missing newlines at the end of several configuration files…
alvarosabu a6ef595
chore: simplify package exports in package.json files and enable auto…
alvarosabu e265af0
chore: update package.json files to include main entry points and pac…
alvarosabu 2f9c55c
fix(core): enhance runtime mode resolution for both browser and Node …
alvarosabu 2c531f0
chore: update package.json files to define main entry points for vari…
alvarosabu 5b06cc1
fix(logger): remove unnecessary eslint directive for explicit any in …
alvarosabu 3185a25
Merge branch 'main' into chore/tsdown-build
alvarosabu c1c37fe
Merge branch 'main' into chore/tsdown-build
alvarosabu 9dd59fc
chore(postprocessing): remove unused build configuration and rollup o…
alvarosabu e275dca
chore: reorganize package dependencies into categorized catalogs in p…
alvarosabu 74a91e9
chore: update tsdown version to 0.16.1 across configurations and pnpm…
alvarosabu f047df8
chore: fix apps/lab running dev and build commands
userquin bfbf5b4
chore: update tsconfig.json for nuxt apps
userquin 5c77640
chore(core): remove exports from tsdown and include node subpackage e…
userquin e2a3675
chore(core): remove exports from tsdown
userquin eb264c8
chore(core): cleanup wrong imports
userquin 0947816
chore: update @tresjs/core peer dependency to allow versions >=5.0.0 …
alvarosabu c6365b6
chore: add missing newline at end of package.json files in cientos an…
alvarosabu 1b08da8
chore: remove exports configuration from tsdown in cientos and postpr…
alvarosabu 7b06293
chore(nuxt): add imports configuration to exclude specific package fi…
alvarosabu dffb107
chore: add shell-emulator configuration to .npmrc for windows
alvarosabu 775df27
chore: update three-custom-shader-material version and configuration …
alvarosabu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| shamefully-hoist=true | ||
| shamefully-hoist=true | ||
| shell-emulator=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,17 @@ | ||
| { | ||
| // https://nuxt.com/docs/guide/concepts/typescript | ||
| "extends": "./.nuxt/tsconfig.json" | ||
| "references": [ | ||
| { | ||
| "path": "./.nuxt/tsconfig.app.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.server.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.shared.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.node.json" | ||
| } | ||
| ], | ||
| "files": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,17 @@ | ||
| { | ||
| // https://nuxt.com/docs/guide/concepts/typescript | ||
| "extends": "./.nuxt/tsconfig.json" | ||
| } | ||
| "references": [ | ||
| { | ||
| "path": "./.nuxt/tsconfig.app.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.server.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.shared.json" | ||
| }, | ||
| { | ||
| "path": "./.nuxt/tsconfig.node.json" | ||
| } | ||
| ], | ||
| "files": [] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be necessary for anyone using the Nuxt module or just in the monorepo?
@userquin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just here, nuxt auto import plugin transforming these modules, resolving those files from the dist folder => on a real app those modules from nodes_modules and wont be transformed by nuxt.
Working at main branch since vite using aliases but auto import also transforming them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can inspect tresleches.js at main using devtools or tres.js in this pr (just compare vite build and tsdown/rolldown build respectively).
This is the nuxt vite plugin causing the build error at apps/lab (I just exclude our dist folders to be transformed):
https://github.com/nuxt/nuxt/blob/07eccf3cb8ab7885a03e2197fd449acff4910bf0/packages/nuxt/src/imports/transform.ts#L23