Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Paginated bl-table multi selection removes previous selections #910

Closed
1 task
ogunb opened this issue Sep 12, 2024 · 2 comments · Fixed by #913
Closed
1 task

[BUG]: Paginated bl-table multi selection removes previous selections #910

ogunb opened this issue Sep 12, 2024 · 2 comments · Fixed by #913

Comments

@ogunb
Copy link
Contributor

ogunb commented Sep 12, 2024

Issue description

Add removes previous page selection:

  1. Select items on the first page.
  2. Navigate to the second page and render different rows.
  3. Click the "Select All" checkbox.
  4. The event includes only the currently rendered page's data, not selections from the previous page.

Remove clears everything:

  1. Select all items on the first page.
  2. Navigate to the second page and select additional rows.
  3. Return to the first page.
  4. Uncheck the "Select All" checkbox.
  5. The event's detail is an empty array, and the selection from the second page is cleared.

In the handleHeaderSelection, only the rows currently rendered should be added or removed from the selection. The function should not modify the entire selected array, but only update it for the visible rows.

Media & Screenshots

No response

Baklava Version

3.1.0

Operating system

  • OS: [e.g. iOS]:

  • Browser [e.g. chrome, safari]:

  • Any other details...

Priority this issue should have

Low (slightly annoying)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@ogunb ogunb added bug Something isn't working bl-table labels Sep 12, 2024
ogunb added a commit that referenced this issue Sep 13, 2024
…ow selections

Otherwise it removes previous selections on paginated table.
#910
@ogunb ogunb closed this as completed in b2fe023 Sep 17, 2024
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant