multiboot2: Switch to using SLRT interface #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergiiDmytruk
force-pushed
the
intel-txt-aem-mb2-slrt
branch
from
12f3a3e to
87f124a
Compare
This was referenced Nov 8, 2023
SergiiDmytruk
force-pushed
the
intel-txt-aem-mb2-slrt
branch
from
87f124a to
94c7f4f
Compare
SergiiDmytruk
force-pushed
the
intel-txt-aem-mb2-slrt
branch
from
94c7f4f to
d702cf5
Compare
Just extract grub_slaunch_add_slrt_policy_entry() calls into separate functions to be able to call them in needed order. Signed-off-by: Sergii Dmytruk <[email protected]>
GRUB_MULTIBOOT(get_mbi_size) doesn't look like an accurate source of the final size, more like a minimal memory buffer size. Signed-off-by: Sergii Dmytruk <[email protected]>
SergiiDmytruk
force-pushed
the
intel-txt-aem-mb2-slrt
branch
from
d702cf5 to
d6cd478
Compare
There was a problem hiding this comment.
With these changes I can boot into Xen, however it still doesn't fully work. Depending on whether I comment out grub_multiboot2_set_video_mode() (to get final lines printed on VGA) Xen either hangs somewhere (if not commented out) or reboots with TXT.ERRORCODE set to 0x8000000a (commented out).
SergiiDmytruk
force-pushed
the
intel-txt-aem-mb2-slrt
branch
from
d6cd478 to
03579a7
Compare
Which commit of TrenchBoot/xen#7 was used? 0x8000000a is that "catch all" error code which doesn't mean much. I guess this also tests changes from #13. |
SergiiDmytruk
force-pushed
the
intel-txt-aem-mb2-slrt
branch
from
03579a7 to
e1bdaf2
Compare
The code makes sure that MBI entry goes first in DRTM, so the payload can measure it first on launch. SLRT table is allocated on the heap first, size for it is reserved inside TXT heap by TXT code and data is later copied into its final place. Signed-off-by: Sergii Dmytruk <[email protected]>
SergiiDmytruk
force-pushed
the
intel-txt-aem-mb2-slrt
branch
from
e1bdaf2 to
b293777
Compare
krystian-hebel
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.