[Fix] Bug de pin/unpin #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliseuramos93
requested review from
rozbr96,
akaninja,
DanSmaR,
gabdemiranda,
hreis1,
caiquedv,
gmkoeb,
Luckvc,
paulohenrique-gh,
GyodaiDDA and
anaresgalla
rozbr96
approved these changes
Feb 16, 2024
gmkoeb
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #247
Durante a apresentação teste, percebemos que após fixar uma publicação na própria timeline, os botões de fixar/desafixar sumiam da página de perfil, sendo necessário sair dela e voltar para o botão reaparecer.
Isso estava acontecendo porque ao fixar/desafixar, o usuário era redirecionado para a própria página mas sem o friendly-id, e por conta disso o botão não era renderizado - sendo necessário sair e voltar para carregar a página com o friendly-id.
Varremos a aplicação para procurar todos redirects que não haviam sido alterados para usar o friendly-id, e adicionamos o slug em cada um deles para corrigir esse bug (e outros eventuais que poderiam existir e não percebemos).