Fix Multi-select Pill Remove #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pill removal button isn't working because the
addEventListeneradded to the remove button intp-multi-select-pillis added in theconstructorinstead ofconnectedCallback. The constructor is called when the pill is created, but that instance doesn't include the remove button as a child. As a result, noaddEventListeneris attached to the pill remove button.Solutions
I see two possible solutions:
addEventListenercode to theconnectedCallback. But the other web components don't follow this and all theaddEventListenerare added directly to theconstructor. To keep it consistent I followed the second approach