Skip to content

Fix Slider Next action when per-view is added #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Fix Slider Next action when per-view is added #58

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2e80108
fix slider next button when per view is added
junaidbhura Mar 20, 2024
180c8f7
fix previous slide with per view
junaidbhura Mar 20, 2024
3e69b43
Add jump to first slide
harshdeep-gill Sep 5, 2024
b5aee1f
Merge with master
harshdeep-gill Sep 5, 2024
5a5ca2f
fix lint errors
harshdeep-gill Sep 5, 2024
b6a16c7
Fix button disable and slider nav in sync with per-view and step
harshdeep-gill Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/slider/tp-slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,11 @@ export class TPSliderElement extends HTMLElement {
// Initialize total slides variable.
const totalSlides: number = this.getTotalSlides();

// Check if we are at the last slide.
if ( this.currentSlideIndex >= totalSlides ) {
// Check if we are at the last slide considering per view attribute.
if ( this.currentSlideIndex >= totalSlides - this.perView + 1 ) {
// Check if we are in infinite mode.
if ( 'yes' === this.getAttribute( 'infinite' ) ) {
// Yes, we are, and go back to first slide.
this.setCurrentSlide( 1 );
}

Expand All @@ -225,7 +226,7 @@ export class TPSliderElement extends HTMLElement {
const nextSlideIndex: number = this.currentSlideIndex + this.step;

// Check if the next slide step is not taking it beyond the last slide.
if ( nextSlideIndex > totalSlides ) {
if ( nextSlideIndex > ( totalSlides - this.perView + 1 ) ) {
// Yes, it is.
return;
}
Expand All @@ -242,7 +243,7 @@ export class TPSliderElement extends HTMLElement {
if ( this.currentSlideIndex <= 1 ) {
// Check if we are in infinite mode.
if ( 'yes' === this.getAttribute( 'infinite' ) ) {
this.setCurrentSlide( this.getTotalSlides() );
this.setCurrentSlide( this.getTotalSlides() - this.perView + 1 );
}

// Terminate.
Expand Down