Skip to content

Multi Select: Fix search issue #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Multi Select: Fix search issue #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aebfe43
Fix search
imranhsayed Jan 21, 2024
ff265cd
Update the select custom event for multiselect
imranhsayed Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@travelopia/web-components",
"version": "0.5.7",
"version": "0.5.8",
"description": "Accessible web components for the modern web",
"files": [
"dist"
Expand Down
10 changes: 8 additions & 2 deletions src/multi-select/tp-multi-select-option.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,16 @@ export class TPMultiSelectOptionElement extends HTMLElement {

if ( 'yes' !== this.getAttribute( 'selected' ) ) {
multiSelect?.select( value );
multiSelect?.dispatchEvent( new CustomEvent( 'select', { bubbles: true } ) );
multiSelect?.dispatchEvent( new CustomEvent( 'select', {
bubbles: true,
detail: { value },
} ) );
} else {
multiSelect?.unSelect( value );
multiSelect?.dispatchEvent( new CustomEvent( 'unselect', { bubbles: true } ) );
multiSelect?.dispatchEvent( new CustomEvent( 'unselect', {
bubbles: true,
detail: { value },
} ) );
}
multiSelect?.dispatchEvent( new CustomEvent( 'change', { bubbles: true } ) );
}
Expand Down
2 changes: 1 addition & 1 deletion src/multi-select/tp-multi-select-search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class TPMultiSelectSearchElement extends HTMLElement {
let matchedOptionCount = 0;
// Hide and show options based on search.
options.forEach( ( option: TPMultiSelectOptionElement ): void => {
if ( option.getAttribute( 'value' )?.match( new RegExp( `.*${ search.value }.*` ) ) ) {
if ( option.getAttribute( 'label' )?.toLowerCase().match( new RegExp( `.*${ search.value.replace( /\s/g, '.*' ) }.*` ) ) ) {
option.removeAttribute( 'hidden' );
matchedOptionCount++;
} else {
Expand Down