Skip to content

QE-1993 fix undefined updateNavItems error in TP slider #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

QE-1993 fix undefined updateNavItems error in TP slider #119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
158803d
QE-1993 fix type error
i-am-chitti Oct 7, 2025
7849c4c
QE-1993 fix typo
i-am-chitti Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/slider/tp-slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,8 @@ export class TPSliderElement extends HTMLElement {
// Initialize total slides variable.
const totalSlides: number = this.getTotalSlides();

// Total Posible groups.
const totalPosibleGroups: number = Math.ceil( totalSlides / this.step );
// Total Possible groups.
const totalPossibleGroups: number = Math.ceil( totalSlides / this.step );

// Initialize previous slide number.
let previousSlideNumber: number = 0;
Expand All @@ -267,13 +267,13 @@ export class TPSliderElement extends HTMLElement {

// Check if we are in the last group or in any other.
if ( this.currentSlideIndex + this.step - 1 >= totalSlides ) {
currentGroup = totalPosibleGroups;
currentGroup = totalPossibleGroups;
} else {
currentGroup = Math.ceil( this.currentSlideIndex / this.step );
}

// Update previous slide number based on which group we are in.
if ( currentGroup === totalPosibleGroups ) {
if ( currentGroup === totalPossibleGroups ) {
previousSlideNumber = this.currentSlideIndex - this.step + 1;
} else {
previousSlideNumber = this.currentSlideIndex - this.step;
Expand Down Expand Up @@ -397,16 +397,22 @@ export class TPSliderElement extends HTMLElement {
* Update stuff when any attribute has changed.
* Example: Update sub-components.
*/
update(): void {
async update(): Promise<void> {
// Get sub-components.
const sliderNav: TPSliderNavElement | null = this.querySelector( 'tp-slider-nav' );
const sliderCounts: NodeListOf<TPSliderCountElement> | null = this.querySelectorAll( 'tp-slider-count' );
const leftArrow: TPSliderArrowElement | null = this.getArrow( 'tp-slider-arrow[direction="previous"]' );
const rightArrow: TPSliderArrowElement | null = this.getArrow( 'tp-slider-arrow[direction="next"]' );

// Total slides variable and Total posible group.
// Wait for initialization - done to avoid updateNavItems undefined error.
await customElements.whenDefined( 'tp-slider-nav' );
await customElements.whenDefined( 'tp-slider-nav-item' );
await customElements.whenDefined( 'tp-slider-count' );
await customElements.whenDefined( 'tp-slider-arrow' );

// Total slides variable and Total possible group.
const totalSlides: number = this.getTotalSlides();
const totalPosibleGroups: number = Math.ceil( totalSlides / this.step );
const totalPossibleGroups: number = Math.ceil( totalSlides / this.step );

// Set active slide.
const slides: NodeListOf<TPSliderSlideElement> | null | undefined = this.getSlideElements();
Expand Down Expand Up @@ -442,7 +448,7 @@ export class TPSliderElement extends HTMLElement {
// Check if index and groups are equal to update active dot.
if ( groupIndex === index ) {
navItem.setAttribute( 'current', 'yes' );
} else if ( ( index === totalPosibleGroups - 1 && this.currentSlideIndex + this.step - 1 >= totalSlides ) ) {
} else if ( ( index === totalPossibleGroups - 1 && this.currentSlideIndex + this.step - 1 >= totalSlides ) ) {
navItem.setAttribute( 'current', 'yes' );

// Remove current index from last 2nd item.
Expand Down