-
Notifications
You must be signed in to change notification settings - Fork 1
Dynamic navigation for TP slider using template #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
junaidbhura
merged 8 commits into
master
from
feature/WP-183-dynamic-navigation-tp-slider-using-template
Apr 2, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cb669a4
Fix navigation issue
monikatravelopia 84b3284
WP-183 Dynamic navigation for TP slider using template
monikatravelopia f9d9b91
Revert navigation fix
monikatravelopia 9913766
WP-183 Add nav based on step
monikatravelopia 9bd7afb
WP-183 Remove multiple spaces
monikatravelopia 2055ef0
WP-183 update dynamic nav items
junaid-travelopia 10af0e4
WP-183 update index file
junaid-travelopia fe118d5
WP-183 update index file
junaid-travelopia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,59 @@ | ||
| /** | ||
| * Internal dependencies. | ||
| */ | ||
| import { TPSliderElement } from './tp-slider'; | ||
|
|
||
| /** | ||
| * TP Slider Nav. | ||
| */ | ||
| export class TPSliderNavElement extends HTMLElement { | ||
| /** | ||
| * Properties. | ||
| */ | ||
| protected template: HTMLTemplateElement | null = null; | ||
| protected slider: TPSliderElement | null = null; | ||
|
|
||
| /** | ||
| * Constructor. | ||
| */ | ||
| constructor() { | ||
| // Initialize parent. | ||
| super(); | ||
|
|
||
| // Get elements. | ||
| this.template = this.querySelector( 'template' ); | ||
| this.slider = this.closest( 'tp-slider' ); | ||
| } | ||
|
|
||
| /** | ||
| * Update nav items based on template. | ||
| */ | ||
| public updateNavItems(): void { | ||
| // Bail if no template. | ||
| if ( ! this.template || ! this.slider ) { | ||
| // Exit. | ||
| return; | ||
| } | ||
|
|
||
| // Total slides. | ||
| const step = Number( this.slider?.getAttribute( 'step' ) ? Number( this.slider?.getAttribute( 'per-view' ) ?? '1' ) : 1 ); | ||
| const totalSlides = Number( this.slider?.getAttribute( 'total' ) ?? 0 ); | ||
junaidbhura marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Calculate the number of navigation items. | ||
| const totalNavItems = Math.ceil( totalSlides / step ); | ||
|
|
||
| // Clear the navigation. | ||
| this.innerHTML = ''; | ||
|
|
||
| // Append the navigation items. | ||
| for ( let i = 1; i <= totalNavItems; i++ ) { | ||
| // Clone the template. | ||
| const navItem: Node = this.template.content.cloneNode( true ); | ||
| const div: HTMLDivElement = document.createElement( 'div' ); | ||
| div.appendChild( navItem ); | ||
|
|
||
| // Append the navigation item. | ||
| this.innerHTML += div.innerHTML.replace( '$index', i.toString() ); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.