Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watford City ND bypass #127

Merged
merged 11 commits into from
Oct 10, 2015
Merged

Conversation

yakra
Copy link
Contributor

@yakra yakra commented Oct 6, 2015

15-10-06;(USA) North Dakota;US 85;nd.us085;Removed from US 85 Business and relocated onto the southwestern Watford City bypass.
15-10-06;(USA) North Dakota;US 85 Business (Watford City);nd.us085buswat;Added route.
15-10-06;(USA) North Dakota;ND 23;nd.nd023;Removed from ND 23 Business between US 85 Business and the southeastern Watford City bypass, and relocated onto the southeastern Watford City bypass between US 85 and ND 23 Business.
15-10-06;(USA) North Dakota;ND 23 Business (Watford City);nd.nd023buswat;Added route.
15-10-06;(USA) North Dakota;ND 200;nd.nd200;Removed from US 85 Business and relocated onto the southwestern Watford City bypass.

yakra added 11 commits October 6, 2015 15:20
sync yakra/master with upstream master 2015-10-06
Removed from US 85 Business and relocated onto the southwestern Watford City bypass.
Removed from ND 23 Business between US 85 Business and the southeastern Watford City bypass, and relocated onto the southeastern Watford City bypass between US 85 and ND 23 Business.
Removed from US 85 Business and relocated onto the southwestern Watford City bypass.
@ovoss
Copy link
Contributor

ovoss commented Oct 7, 2015

I'd appreciate your adding OldUS85_N and _S points to the US85 and US85BusWat files, where both peel away from the old US 85 alignment. The junctions between the mainline and business routes leaves more than usual stranded old pavement, and the extra points would best reflect that.

Also, suggest the north endpoint be renamed from ND/Can to either ND/SK or USA/Can, to be consistent with other international border points.

@ovoss ovoss closed this Oct 7, 2015
@jteresco
Copy link
Contributor

jteresco commented Oct 7, 2015

I think @ovoss closed this by mistake so I'm reopening. I'm not going to merge it in right now in case @yakra would like to include the @ovoss suggestions.

@jteresco jteresco reopened this Oct 7, 2015
@ovoss
Copy link
Contributor

ovoss commented Oct 7, 2015

Thanks, Jim -- my close was indeed by mistake, while I was removing a duplicate comment.

Looking again at US85BusWat, it looks like ND23_E is where an OldUS85_S point would go, so no new point needed there. Still needs an OldUS85_N point, to reflect my travels on former US 85 through Watford City,

@jteresco
Copy link
Contributor

jteresco commented Oct 9, 2015

Holding off on this one for tonight. Let me know if all is set and I should merge.

@yakra
Copy link
Contributor Author

yakra commented Oct 10, 2015

If I update the files in my local branch, will merging his request pull in my newest revisions of the files, or just the earlier commits listed above?

@jteresco
Copy link
Contributor

@yakra You can add commits to an open pull request, or if it's easier, just open a new one with either all of the changes or just the additional ones.

@yakra
Copy link
Contributor Author

yakra commented Oct 10, 2015

Unsure immediately how to add new commits. How about we merge this one in, and then I add in the *OldUS85 points in in a future pull request?

Oscar, WRT US85BusWat and the usual amount of stranded old pavement:
Is OldUS85 http://www.openstreetmap.org/?lat=47.804421&lon=-103.352278 fine, or
would you prefer *OldUS85 http://www.openstreetmap.org/?lat=47.804674&lon=-103.350229 ?

@jteresco
Copy link
Contributor

Sure. Merging this one in.

jteresco added a commit that referenced this pull request Oct 10, 2015
@jteresco jteresco merged commit a737cf9 into TravelMapping:master Oct 10, 2015
jteresco added a commit that referenced this pull request Oct 10, 2015
@ovoss
Copy link
Contributor

ovoss commented Oct 11, 2015

The first (oldUS85) seems better to me than the second (*OldUS85), The second is slightly more perfect, but the first is close enough for me, and that it's at an actual intersection makes it better.

Oscar

----- Original Message -----

From: "Eric Bryant" [email protected]
To: "TravelMapping/HighwayData" [email protected]
Cc: "ovoss" [email protected]
Sent: Saturday, October 10, 2015 3:31:02 PM
Subject: Re: [HighwayData] Watford City ND bypass (#127)

Unsure immediately how to add new commits. How about we merge this one in, and then I add in the *OldUS85 points in in a future pull request?

Oscar, WRT US85BusWat and the usual amount of stranded old pavement:
Is OldUS85 http://www.openstreetmap.org/?lat=47.804421&lon=-103.352278 fine, or
would you prefer *OldUS85 http://www.openstreetmap.org/?lat=47.804674&lon=-103.350229 ?


Reply to this email directly or view it on GitHub .

@yakra
Copy link
Contributor Author

yakra commented Oct 11, 2015

I've added OldUS85 to US85BusWat in my repository.

US85 proper:
For the southern point, the old/new split lines up just about exactly with the realigned 24th St intersection, so I've added the point there:
24thSt http://www.openstreetmap.org/?lat=47.754351&lon=-103.283178
For the northern point, I'd place it about here:
*OldUS85 http://www.openstreetmap.org/?lat=47.804731&lon=-103.367239
Or, I could slide it a tiny bit west to the actual intersection of 130th Ave. Thoughts?

@ovoss
Copy link
Contributor

ovoss commented Oct 12, 2015

All of these are fine with me, including using 130thSt instead of the northern OldUS85 point.

Oscar

----- Original Message -----

From: "Eric Bryant" [email protected]
To: "TravelMapping/HighwayData" [email protected]
Cc: "ovoss" [email protected]
Sent: Sunday, October 11, 2015 10:41:29 AM
Subject: Re: [HighwayData] Watford City ND bypass (#127)

I've added OldUS85 to US85BusWat in my repository.

For US85 proper:
For the southern point, the old/new split lines up just about exactly with the new realigned 24th st intersection, so I've added the point there:
24thSt http://www.openstreetmap.org/?lat=47.754351&lon=-103.283178
For the northern point, I'd place it about here:
*OldUS85 http://www.openstreetmap.org/?lat=47.804731&lon=-103.367239
Or, I could slide it a tiny bit west to the actual intersection of 130th Ave. Thoughts?


Reply to this email directly or view it on GitHub .

@yakra
Copy link
Contributor Author

yakra commented Oct 12, 2015

I'll use 130thAve, then. Heck, it's what I did with the US54/400 Cunningham KS bypass.

@yakra yakra mentioned this pull request Oct 12, 2015
@yakra
Copy link
Contributor Author

yakra commented Oct 12, 2015

#133

@the-spui-ninja
Copy link
Contributor

Just to let you know, the concurrency between ND 200 and US 85 is now broken. I think the points need to be added to ND 200's file as well.

@yakra
Copy link
Contributor Author

yakra commented Oct 14, 2015

Derp! Thanks.
Submitted #135.

jteresco pushed a commit that referenced this pull request Jun 27, 2017
jteresco pushed a commit that referenced this pull request Dec 22, 2018
jteresco pushed a commit that referenced this pull request Oct 16, 2022
Nice. No, not for the reason you think.
jteresco pushed a commit that referenced this pull request Oct 20, 2022
go on confusing the soul hold my breath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants