Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Docker image needs fixing before it can be used as a Github repository #119

Open
gaurav opened this issue Mar 24, 2023 · 1 comment

Comments

@gaurav
Copy link
Collaborator

gaurav commented Mar 24, 2023

One nice feature of the GitHub Docker image generated by PR #106 is that it includes the .git directory, so that it can be used as a Git repository. This is hugely helpful in development, since I can switch to a new branch and try that code out very easily when Babel is run on a Kubernetes node.

However, there is one flaw with this .git directory: one of our GitHub action steps (probably docker/login-action@v1) uses Basic authentication to authenticate with GitHub. This instruction remains in the .git/config file, and needs to be manually deleted before git fetch will work.

There must be a way of configuring this action so it doesn't do this, or of removing this section before creating the Docker image, but since it's relatively easy to fix by hand, I'm going to file this away for later.

@gaurav gaurav added this to the Babel May 2023 Release milestone Mar 24, 2023
gaurav added a commit that referenced this issue May 11, 2023
This PR adds a GitHub Action that will generate Docker images from this repo for all releases. Closes #99.

There is a known issue with using `git fetch` in the resulting Docker image, but it is pretty easy to fix manually: #119
@gaurav
Copy link
Collaborator Author

gaurav commented Nov 14, 2023

It looks like this can be fixed by setting persist-credentials: false in the settings as per https://github.com/marketplace/actions/checkout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant