Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add error for empty transfer count when leg group ids match #21

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Fix: add error for empty transfer count when leg group ids match #21

merged 3 commits into from
Jul 4, 2022
+10 −7

Conversation

jsteelz
Copy link
Member

@jsteelz jsteelz commented Jul 4, 2022

Fixes #20

@jsteelz jsteelz requested a review from npaun July 4, 2022 15:56
npaun
npaun approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@npaun npaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to bump version in setup.py

@jsteelz jsteelz merged commit bdcd086 into master Jul 4, 2022
@jsteelz jsteelz deleted the fix/conditional-transfer-count-validation branch July 4, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npaun npaun npaun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise error when transfer_count is required but absent from fare_transfer_rules.txt
2 participants
@jsteelz @npaun