Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First revision #2
First revision #2
Changes from 48 commits
35b73a9
5b08b98
11244b3
f1fc60e
46f7b2f
f3809bb
816f6fe
e716e10
d7ebc6b
c78f93e
dac3f9d
5f35e70
e3b867e
373fc38
c029ee2
0e64a1d
55f39b9
17adae5
128218f
5fc0ac2
e4fea18
9691776
c70f8ba
77cc7a9
6fb656d
75c4ef1
761eac4
2a92c4e
f662ead
52f424d
fb115b0
86ae4fd
51db0f6
2307ed9
4f29347
fe9b8a8
03e3053
847d6a9
b744e8e
2f5422f
8cce939
cbc7058
a7f884c
b3e1c83
ece6b9c
70a8711
d5c3ab6
a89f640
34395e1
93d636d
7f2a96a
cd7a2c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just for trips that are detected, right? or are we overwriting all transfers with trip_ids defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature doesn't really work properly, but the intention is that if you already have both block IDs and trip-to-trip transfers in your feed, it should avoid trashing your existing transfers.