Skip to content

Conversation

@bryce13950
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

bryce13950 and others added 15 commits May 5, 2025 18:47
* created a seperate list of models to test for public PRs

* ran format
* Fix loading on specific device

* format

---------

Co-authored-by: Bryce Meyer <[email protected]>
* Implement Qwen3 qk normalization

* Add QK norm to correct class

* reuse module

* format

* alias

* remove qk norm eps

* updated notebook

* reran notebook

* fixed mypy issues in conversion

* checked q norm and k norm value before use

---------

Co-authored-by: fellows-safety <[email protected]>
Co-authored-by: Bryce Meyer <[email protected]>
* updated mypy

* fixed mypy issues

* restored neel nanda config

* fixed typing

* removed extra reference

* restored model aliases

* restored python 3.9 compatibility

* removed irrelevant test

* ran format

* fixed import

* restored python 3.9 items
* upated torch

* fixed some mypy issues

* fixed some mypy issues

* fixed param passing

* updated some dependencies

* fixed test

* ran format

* ran format

* fixed some mypy issues

* fixed mypy issues

* fixed mypy issues in HookedTransformer

* fixed abstract attention mypy issues

* fixed attention bug

* fixed mypy issues

* fixed potential name collision

* asserted type

* fixed param

* ignored type check
* updated transformers

* updated torch

* updated mypy

* updated mypy dependency

* lowered ceiling of mypy

* removed mypy ceiling

* capped mypy

* fixed some more mypy transformers incompatibilities

* restored pythong 3.9 compat

* fixed mypy errors

* ran format

* fixed mypy issues

* fixed more mypy issues

* fixed another mypy issue

* fixed test
@bryce13950 bryce13950 merged commit e1c7506 into main Jun 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants