Skip to content

Feature: Get the value for rotary base from the hugging face config, only for Qwen for now. #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Feature: Get the value for rotary base from the hugging face config, only for Qwen for now. #887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
132df27
Get the value for rotary base from the hugging face config
Gusanidas Feb 27, 2025
6fac4c7
Merge branch 'dev' into feature/rope-theta-from-hf-config
bryce13950 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions transformer_lens/loading_from_pretrained.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,9 +1170,11 @@ def convert_hf_model_config(model_name: str, **kwargs):
use_local_attn = True if hf_config.sliding_window else False
cfg_dict = {
"d_model": hf_config.hidden_size,
"d_head": hf_config.head_dim
if hasattr(hf_config, "head_dim") and hf_config.head_dim > 0
else hf_config.hidden_size // hf_config.num_attention_heads,
"d_head": (
hf_config.head_dim
if hasattr(hf_config, "head_dim") and hf_config.head_dim > 0
else hf_config.hidden_size // hf_config.num_attention_heads
),
"n_heads": hf_config.num_attention_heads,
"d_mlp": hf_config.intermediate_size,
"n_layers": hf_config.num_hidden_layers,
Expand Down Expand Up @@ -1736,6 +1738,8 @@ def get_pretrained_model_config(
if hf_cfg is not None:
cfg_dict["load_in_4bit"] = hf_cfg.get("quantization_config", {}).get("load_in_4bit", False)
cfg_dict["d_vocab"] = hf_cfg.get("vocab_size", cfg_dict["d_vocab"])
if cfg_dict["original_architecture"] == "Qwen2ForCausalLM":
cfg_dict["rotary_base"] = hf_cfg.get("rope_theta", cfg_dict["rotary_base"])
if first_n_layers is not None:
cfg_dict["n_layers"] = first_n_layers

Expand Down