Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix: Add nativelink-debug target #811

Conversation

adam-singer
Copy link
Contributor

@adam-singer adam-singer commented Mar 29, 2024

Description

Adding a nix target that allows for enabling console or other features as needed for debugging nativelink images.

Fixes # (issue)

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@adam-singer adam-singer force-pushed the adams/add-nativelink-debug-with-console branch from ae462f6 to ec35ade Compare March 29, 2024 00:09
@adam-singer adam-singer requested a review from aaronmondal March 29, 2024 00:10
@adam-singer adam-singer marked this pull request as ready for review March 29, 2024 00:10
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@adam-singer adam-singer merged commit c60fb55 into TraceMachina:main Apr 1, 2024
26 checks passed
@adam-singer adam-singer deleted the adams/add-nativelink-debug-with-console branch April 1, 2024 18:06
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants