Build nativelink with musl #583
Conversation
|
@blakehatch can you check this on the Mac please? |
|
I will also, later today sometime |
There was a problem hiding this comment.
@MarcusSorealheis This executable won't work on mac. The statically linked musl still calls into the Linux kernel which Mac doesn't have.
However, this should make it a lot easier to get the same thing working for mac in a future commit since musl does support mac. We'll need a separate build job for that but it should be very close to this linux build.
Reviewable status: 0 of 1 LGTMs obtained
|
I don't think we can change this in that case just yet. Or, if we do, we'd need to do a lot to offer a path that does work for users building on a Mac. Many of our users are on Mac OS, certainly from a building from source lens. |
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
flake.nix line 54 at r1 (raw file):
}; craneLib = crane.lib.${system};
Ah my bad. I thought we only supported the native Cargo build on mac. But we actually did have a working Mac build here that was just not tracked in CI i think. So I definitely should add mac support in this change as well.
Reduce container image sizes by over 50% to about 28 megabytes. The nativelink executable is now fully self-contained and portable across linux systems regardless of the host's libc. This change introduces new Rust toolchains on the nix side that mirror the Bazel toolchains. The new toolchains enable `cargo clippy` invocations without Bazel and allow invoking the same nightly `rustfmt` that is used in the Bazel build via pre-commit hooks.
There was a problem hiding this comment.
I've added Mac support back. This commit should now be a no-op change for MacOS.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), pre-commit-checks, publish-image, ubuntu-20.04, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable
There was a problem hiding this comment.
Tested on MacOS
nix develop
nix build
cargo test --all
Reviewed 3 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained
Reduce container image sizes by over 50% to about 28 megabytes.
The nativelink executable is now fully self-contained and portable across linux systems regardless of the host's libc.
This change introduces new Rust toolchains on the nix side that mirror the Bazel toolchains. The new toolchains enable
cargo clippyinvocations without Bazel and allow invoking the same nightlyrustfmtthat is used in the Bazel build via pre-commit hooks.This change is