Build toolchain-examples #1971
Merged
Build toolchain-examples #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palfrey
commented
Oct 13, 2025
| @@ -1,6 +1,3 @@ | |||
| # Don't use the host's default PATH and LD_LIBRARY_PATH. | |||
| build --incompatible_strict_action_env | |||
|
|
|||
Member
Author
There was a problem hiding this comment.
This causes env: 'bash': No such file or directory in the Java, Go and Python examples, even with bazel-contrib/rules_go#4465 to improve bash paths.
palfrey
commented
Oct 13, 2025
| @@ -7,10 +7,10 @@ module( | |||
| compatibility_level = 0, | |||
| ) | |||
|
|
|||
| bazel_dep(name = "platforms", version = "0.0.11") | |||
| bazel_dep(name = "platforms", version = "1.0.0") | |||
Member
Author
There was a problem hiding this comment.
Various upgrades were done for improved Nix compatibility, plus things that transitively depended on those.
palfrey
force-pushed
the
toolchain-examples-ci
branch
from
7a01bc0 to
7ca1bb8
Compare
Collaborator
|
I tested these examples out as specified in the docs for the toolchain examples. It works fine on my machine with the |
palfrey
force-pushed
the
toolchain-examples-ci
branch
from
7ca1bb8 to
eedad85
Compare
palfrey
force-pushed
the
toolchain-examples-ci
branch
from
eedad85 to
777b506
Compare
palfrey
force-pushed
the
toolchain-examples-ci
branch
from
777b506 to
29b44b9
Compare
palfrey
force-pushed
the
toolchain-examples-ci
branch
from
cec261c to
4519cdc
Compare
palfrey
force-pushed
the
toolchain-examples-ci
branch
from
4519cdc to
b06ef5f
Compare
amankrx
approved these changes
Oct 16, 2025
Collaborator
amankrx
left a comment
amankrx
left a comment
There was a problem hiding this comment.
Tested locally on a Mac machine. Works as expected.
palfrey
force-pushed
the
toolchain-examples-ci
branch
from
b06ef5f to
44e6483
Compare
palfrey
force-pushed
the
toolchain-examples-ci
branch
from
44e6483 to
8a4e70e
Compare
MarcusSorealheis
approved these changes
Oct 16, 2025
MarcusSorealheis
pushed a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds the examples in
toolchain-examplesso we don't accidentally break them.Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Mostly via the test step added in this PR, which tests everything in https://nativelink.com/docs/rbe/remote-execution-examples (with the exception of
abseil-cppand the rust target, both of which have errors with remote execution, as documented)Checklist
bazel test //...passes locallygit amendsee some docsThis change is