Chromium blog post #1551
Draft
Chromium blog post #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
reviewed
Dec 19, 2024
There was a problem hiding this comment.
FYI @MarcusSorealheis Some of the information here is outdated and won't work out of the box. I'll see if I can get the chromium example up to speed again and ping you when I have an update.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 1 files reviewed, and pending CI: docker-compose-compiles-nativelink (22.04)
|
@aaronmondal that makes sense. I am just trying to get this out because it never was completed for months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here is a Chromium blogpost that was never finished and shipped.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Waiting for deployment preview.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is