-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support digest function in GrpcStore
#1548
base: main
Are you sure you want to change the base?
Conversation
Please do not open up PRs that do not adhere to the checklist, unless they do not impact NativeLink. |
6b47cd7
to
8b954aa
Compare
The failed check before isn't known what it is failed for seems a deployment failure! Hopefully the deployments succeeded now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@allada @MarcusSorealheis What do we do about test coverage here? The grpcStore currently has no tests 😅 https://tracemachina.github.io/nativelink/coverage/build/source/nativelink-store/src/grpc_store.rs.html
@asr2003 I think it should be fine if we just cover the changed parts, i.e. unit tests for the read
, has_with_results
and is_supported_digest_function
, and only tests that trigger the branches that you added (i.e. tests that force the new error handling and check that they're actually hit).
Reviewable status: 0 of 2 LGTMs obtained, and 0 of 2 files reviewed (waiting on @allada)
Sure! I will add tests to ensure the branch coverage. |
@aaronmondal To validate the Here's what I have mocked for and looking part of unit test but fails :)
Correct me if I am wrong in mocking GRPC Store for unit tests |
c1bf8c1
to
d09fbcc
Compare
Description
ResourceInfo
to defaultdigest_function
tosha256
if not provided.Fixes #1325
/claim #1325
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Please also list any relevant details for your test configuration
Tests added
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is