[Bug] Add rt-tokio feature to aws-sdk-s3 #1248
Conversation
Feature `rt-tokio` had been transitively dependended on, durning refactors of `Cargo.toml` files it was accidentally dropped.
|
Thank you for fixing this one. It goes without saying that this will be in our point release. |
There was a problem hiding this comment.
It would be nice to have some sort of regression test for this (or at least an issue that tracks implementation of a regression test).
I'll create a point release after this is merged.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
nativelink-store/Cargo.toml line 17 at r1 (raw file):
"rustls", ] } aws-sdk-s3 = { version = "1.41.0", features = [
nit: Is there a way we could add a regression test or something? Maybe just a feature-check in the source for the S3 store so that builds fail early if this accidentally removed again in the future?
There was a problem hiding this comment.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
nativelink-store/Cargo.toml line 17 at r1 (raw file):
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
nit: Is there a way we could add a regression test or something? Maybe just a feature-check in the source for the S3 store so that builds fail early if this accidentally removed again in the future?
This should have been caught in CI, the reason it didnt was because aws-sdk-s3 has to be defined in dev-dependencies (below) as well as here, but only got enabled below.
Writing a regression test for this is not going to be easy, because it will require a full integration test.
There was a problem hiding this comment.
The test could of been something that asserts what the defaults provided from the library, as @allada it was a feature enabled in dev deps so we would still have missed it. We could.. put an assert in the main code upon init to halt if the credential provider util isn't returning expected sleep functions, don't think its the right place, integration tests would be better.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
Description
Feature
rt-tokiohad been transitively dependended on, durning refactors ofCargo.tomlfiles it was accidentally dropped.Fixes #1247
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Will be deployed to staging systems.
This change is