-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing The Overhauled NativeLink Documentation #1138
Conversation
58dcb62
to
ce5f9f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post a link to the preview of the rendering of the documentation?
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), macos-13, pre-commit-checks, windows-2022 / stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blakehatch Before we go into the details:
- Split off the changes to
metaphase.ts
andmd_to_mdx.ts
into one or two separate PRs.
For this PR:
-
The following files should not be part of the PR as they're autogenerated. Instead they should be in the
docs/.gitignore
:chromium.mdx
kubernetes.mdx
setup.mdx
- I may have overlooked a file or two (like the config explantations?), please double-check.
-
Revisit the change to
accept.txt
. Note that in it's current state your changes are not entirely correct. Various terms added here are not correct. For instancesize_partitioning
is not a word andlru
should only be allowed capitalized asLRU
. -
Please make sure that any non-generated (i.e. "true" new content) passes vale with a
warning
level configuration:- Change this to warning:
Line 5 in 5810489
MinAlertLevel = error - Add a bogus obviously wrong word in any README to trigger a vale erorr on it.
- When you now run
pre-commit run -a
it'll show you vale warnings. Ignore the warnings from generated and existing files, but make sure that no new warnings are introduced from the new content.
- Change this to warning:
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: pre-commit-checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: pre-commit-checks
15d67e0
to
f49b322
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the links working?
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable
f49b322
to
c7287fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah they are just splitting into a two PRs and doing a final pass with @aaronmondal rn. These will get in tonight
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable
f72c433
to
9decf73
Compare
9decf73
to
0d4d76e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 32 files at r1, 7 of 11 files at r2, 13 of 13 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable
This is a total overhaul of our documentation
Preview Deployment: nativelink-31n.pages.dev
This docs update implements two primary ethos:
I have made attempts to create as little new content in this documentation as possible, pulling from many helpful contributions of useful peer-reviewed documentation most notably examples of actual production configs and deployments from @kubevalet.
:::Note
When reviewing please focus on the structure and avoid diving into nits on the content due to the scale of this, obviously blatantly incorrect content can be addressed here. This is intended to be a jumping-off point for many updates and improvements for other maintainers.
In other words to fix the cold-start problem the sparseness of the previous docs presented.
So if you want to completely change a section, please open a new PR on top of this one to overhaul individual sections.
:::
Notable new sections of content include:
FAQ
Introduction
Bug fixes
This change is