Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientAwaitedAction now uses a channel to notify drops happened #1130

Merged
merged 1 commit into from
Jul 10, 2024
Merged

ClientAwaitedAction now uses a channel to notify drops happened #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion nativelink-scheduler/src/cache_lookup_scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ impl ActionScheduler for CacheLookupScheduler {
.await;
match maybe_action_result {
Ok(action_result) => {
println!("{action_result:?}");
let maybe_pending_txs = {
let mut inflight_cache_checks = inflight_cache_checks.lock();
// We are ready to resolve the in-flight actions. We remove the
Expand Down
2 changes: 1 addition & 1 deletion nativelink-scheduler/src/scheduler_state/awaited_action.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ pub struct AwaitedAction {
action_info: Arc<ActionInfo>,

// The unique identifier of the operation.
// TODO(operation_id should be stored here).
// TODO!(operation_id should be stored here).
// operation_id: OperationId,
/// The data that is used to sort the action in the queue.
/// The first item in the tuple is the current priority,
Expand Down
Loading