Skip to content

Commit

Permalink
ClientAwaitedAction now uses a channel to notify drops happened
Browse files Browse the repository at this point in the history
Instead of using Weak references and custom spawns, we now use
a channel to notify receivers that cleanups are needed.
  • Loading branch information
allada committed Jul 10, 2024
1 parent 52beaf9 commit 4359e9b
Show file tree
Hide file tree
Showing 2 changed files with 139 additions and 147 deletions.
2 changes: 1 addition & 1 deletion nativelink-scheduler/src/scheduler_state/awaited_action.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ pub struct AwaitedAction {
action_info: Arc<ActionInfo>,

// The unique identifier of the operation.
// TODO(operation_id should be stored here).
// TODO!(operation_id should be stored here).
// operation_id: OperationId,
/// The data that is used to sort the action in the queue.
/// The first item in the tuple is the current priority,
Expand Down
Loading

0 comments on commit 4359e9b

Please sign in to comment.