Fix clippy::manual_string_new (#1106)

TraceMachina · Jul 19, 2024 · 3992aef · 3992aef
1 parent 9948737
commit 3992aef
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/.bazelrc b/.bazelrc
@@ -41,7 +41,7 @@ build --aspects=@rules_rust//rust:defs.bzl%rustfmt_aspect
 build --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect
 
 # TODO(aaronmondal): Extend these flags until we can run with clippy::pedantic.
-build --@rules_rust//:clippy_flags=-Dwarnings,-Dclippy::uninlined_format_args
+build --@rules_rust//:clippy_flags=-Dwarnings,-Dclippy::uninlined_format_args,-Dclippy::manual_string_new
 build --@rules_rust//:clippy.toml=//:clippy.toml
 
 test --@rules_rust//:rustfmt.toml=//:.rustfmt.toml

diff --git a/nativelink-scheduler/tests/simple_scheduler_test.rs b/nativelink-scheduler/tests/simple_scheduler_test.rs
@@ -601,7 +601,7 @@ async fn cacheable_items_join_same_action_queued_test() -> Result<(), Error> {
     let action_digest = DigestInfo::new([99u8; 32], 512);
 
     let unique_qualifier = ActionUniqueQualifier::Cachable(ActionUniqueKey {
-        instance_name: "".to_string(),
+        instance_name: String::new(),
         digest: DigestInfo::zero_digest(),
         digest_function: DigestHasherFunc::Sha256,
     });
@@ -1158,7 +1158,7 @@ async fn does_not_crash_if_operation_joined_then_relaunched() -> Result<(), Erro
     let action_digest = DigestInfo::new([99u8; 32], 512);
 
     let unique_qualifier = ActionUniqueQualifier::Cachable(ActionUniqueKey {
-        instance_name: "".to_string(),
+        instance_name: String::new(),
         digest: DigestInfo::zero_digest(),
         digest_function: DigestHasherFunc::Sha256,
     });

diff --git a/nativelink-service/src/capabilities_server.rs b/nativelink-service/src/capabilities_server.rs
@@ -137,13 +137,13 @@ impl Capabilities for CapabilitiesServer {
                 major: 2,
                 minor: 0,
                 patch: 0,
-                prerelease: "".to_string(),
+                prerelease: String::new(),
             }),
             high_api_version: Some(SemVer {
                 major: 2,
                 minor: 3,
                 patch: 0,
-                prerelease: "".to_string(),
+                prerelease: String::new(),
             }),
         };
         Ok(Response::new(resp))

diff --git a/nativelink-service/src/cas_server.rs b/nativelink-service/src/cas_server.rs
@@ -184,7 +184,7 @@ impl CasServer {
                             // Trim the error code. Not Found is quite common and we don't want to send a large
                             // error (debug) message for something that is common. We resize to just the last
                             // message as it will be the most relevant.
-                            e.messages.resize_with(1, || "".to_string());
+                            e.messages.resize_with(1, String::new);
                         }
                         (e.into(), Bytes::new())
                     },

diff --git a/nativelink-service/tests/cas_server_test.rs b/nativelink-service/tests/cas_server_test.rs
@@ -198,7 +198,7 @@ async fn update_existing_item() -> Result<(), Box<dyn std::error::Error>> {
                 digest: Some(digest),
                 status: Some(GrpcStatus {
                     code: 0, // Status Ok.
-                    message: "".to_string(),
+                    message: String::new(),
                     details: vec![],
                 }),
             },],
@@ -269,7 +269,7 @@ async fn batch_read_blobs_read_two_blobs_success_one_fail() -> Result<(), Box<dy
                         data: VALUE1.into(),
                         status: Some(GrpcStatus {
                             code: 0, // Status Ok.
-                            message: "".to_string(),
+                            message: String::new(),
                             details: vec![],
                         }),
                         compressor: compressor::Value::Identity.into(),
@@ -279,7 +279,7 @@ async fn batch_read_blobs_read_two_blobs_success_one_fail() -> Result<(), Box<dy
                         data: VALUE2.into(),
                         status: Some(GrpcStatus {
                             code: 0, // Status Ok.
-                            message: "".to_string(),
+                            message: String::new(),
                             details: vec![],
                         }),
                         compressor: compressor::Value::Identity.into(),
@@ -577,15 +577,15 @@ async fn batch_update_blobs_two_items_existence_with_third_missing(
                         digest: Some(digest1),
                         status: Some(GrpcStatus {
                             code: 0, // Status Ok.
-                            message: "".to_string(),
+                            message: String::new(),
                             details: vec![],
                         }),
                     },
                     batch_update_blobs_response::Response {
                         digest: Some(digest2),
                         status: Some(GrpcStatus {
                             code: 0, // Status Ok.
-                            message: "".to_string(),
+                            message: String::new(),
                             details: vec![],
                         }),
                     }

diff --git a/nativelink-store/src/ac_utils.rs b/nativelink-store/src/ac_utils.rs
@@ -64,7 +64,7 @@ pub async fn get_size_and_decode_digest<T: Message + Default + 'static>(
             // Trim the error code. Not Found is quite common and we don't want to send a large
             // error (debug) message for something that is common. We resize to just the last
             // message as it will be the most relevant.
-            err.messages.resize_with(1, || "".to_string());
+            err.messages.resize_with(1, String::new);
         }
     }
     let store_data = store_data_resp?;

diff --git a/nativelink-util/src/action_messages.rs b/nativelink-util/src/action_messages.rs
@@ -600,7 +600,7 @@ pub struct ExecutionMetadata {
 impl Default for ExecutionMetadata {
     fn default() -> Self {
         Self {
-            worker: "".to_string(),
+            worker: String::new(),
             queued_timestamp: SystemTime::UNIX_EPOCH,
             worker_start_timestamp: SystemTime::UNIX_EPOCH,
             worker_completed_timestamp: SystemTime::UNIX_EPOCH,
@@ -725,7 +725,7 @@ impl Default for ActionResult {
             stdout_digest: DigestInfo::new([0u8; 32], 0),
             stderr_digest: DigestInfo::new([0u8; 32], 0),
             execution_metadata: ExecutionMetadata {
-                worker: "".to_string(),
+                worker: String::new(),
                 queued_timestamp: SystemTime::UNIX_EPOCH,
                 worker_start_timestamp: SystemTime::UNIX_EPOCH,
                 worker_completed_timestamp: SystemTime::UNIX_EPOCH,