Plan: pilot allowlist implementation - #108
Merged
Merged
Conversation
Implementation plan against docs/superpowers/specs/2026-05-17-pilot-allowlist-design.md (merged in PR #107). Three slices, ten tasks. No new direct deps. Slice 1 — invite_code field on WorkloadClaims, policy_label on UploadClaimClaims, AllowlistSource trait + FileAllowlistSource with refresh-cached snapshots. Slice 2 — wire the snapshot check into the issuance handler, emit policy_label on the minted claim, integration tests for the round-trip. Slice 3 — DenialCounter, /v1/admin/allowlist-status on an optional localhost-only second axum bind, operator runbook, --hash-invite-code CLI helper. Risk register covers the five things most likely to bite: raw codes committed by mistake, file deletion in production, admin endpoint accidental public exposure, signers unaware of the new field, hashing drift between operator and issuer. Executor guidance pinned at the bottom: no refactor of the existing 1,643-line issuer module, no logging of raw invite codes, admin endpoint is optional, no new direct deps.
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What's in the plan, what's not
Verification
Each slice ends with the four CI commands the repo already enforces (`cargo check`, `cargo test --no-run`, `cargo clippy`, `cargo fmt --check`) plus the new module-targeted `cargo test trace_upload_claim_allowlist`. Full `cargo test -p trace-commons-server` green at end-of-plan is the exit criterion.
Test plan