Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Antox client with aTox #228

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Conversation

nurupo
Copy link
Member

@nurupo nurupo commented Jan 15, 2021

Antox hasn't been maintained for a long time now.

aTox is a new Android client developer by one of the core Tox developers.

Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

icon: "download",
desc: true,
dlLink: "https://pkg.tox.chat/fdroid/repo/antox.apk",
dlLink: "https://github.com/evilcorpltd/aTox/releases/download/v0.5.1/atox.apk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really mean to version lock it to v0.5.1? Seems like it'll go out of date both quickly and often

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you can't use latest for direct file downloads, e.g. https://github.com/evilcorpltd/aTox/releases/download/latest/atox.apk is a HTTP 404.

What do you suggest to do instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's merge this as it is and change the URL later when you reply with what you had on your mind. Doesn't make much sense to stall the PR for this.

Antox hasn't been maintained for a long time now.
aTox is a new Android client developed by one of the core Tox
developers.
@nurupo nurupo merged commit 696cdee into Tox:master Jan 16, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants