Remove magic values from spawnpoint ring offsets #7267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
approved these changes
Feb 18, 2024
LlmDl
added a commit
that referenced
this pull request
Feb 19, 2024
Warrior with PR #7267. - Fix mob removal on folia, courtesy of Warrior with PR #7262. - Closes #7261, #7221, #7202, #7253. - Make our custom registered commands identifiable, courtesy of Warrior with PR #7263. - Move using_economy to the eco section of the config, courtesy of Warrior with PR #7265. - Automatic config edit: - plugin.interfacing.using_economy moves to economy.using_economy - Remove uuid percentage tracking, courtesy of Warrior with PR #7266. - Make PlotClaim a runnable, courtesy of Warrior with PR #7268. - Reorganize test directory layout, courtesy of Warrior with PR #7269.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Calculates the offsets for the points in spawn point circles instead of using precalculated values, the benefit of this is that it's easier to see what it's doing and makes it easier to make changes to it. Due to imprecision the offsets won't be exactly the same but the difference isn't significant
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.