Seperate the load and save data sources #7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
reviewed
Dec 21, 2023
Comment on lines
+123
to
+127
| synchronized(queryQueue) { | ||
| while (!this.queryQueue.isEmpty()) { | ||
| Runnable operation = this.queryQueue.poll(); | ||
| operation.run(); | ||
| } |
There was a problem hiding this comment.
Using this synchronized, is this how we get around the issue that required the SQL source to use the isPolling variable?
LlmDl
added a commit
that referenced
this pull request
Dec 26, 2023
- Update Towny/Sponsor plugins list. - Correct townblock reporting in debug messages no one sees. - Make the TownyUniverse code a bit more readable. - Seperate the load and save data sources, courtesy of Warrior with PR #7100. - Fixes a minor memory/connection leak when using mysql, the load datasource is now properly shut down when it's no longer needed and re-used if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a minor memory/connection leak when using mysql, the load datasource is now properly shut down when it's no longer needed and re-used if possible. By re-using it we also avoid doing some double work, such as all the tables being checked & altered, which saves a bit of time.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.