Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When an attachable block is blown up by an explosion, it drops, but also regenerates, duplicating it. #7154

Closed
blockutis opened this issue Jan 1, 2024 · 2 comments · Fixed by #7176
Closed

When an attachable block is blown up by an explosion, it drops, but also regenerates, duplicating it. #7154

blockutis opened this issue Jan 1, 2024 · 2 comments · Fixed by #7176
Assignees
@LlmDl
Labels
bug Completed
Milestone
0.100.1.0

Comments

@blockutis
Copy link

What steps will reproduce the problem?

  1. Start the server, with no other plugins installed
  2. Create a small platform (3x3) of blocks, such as dirt.
  3. Place attachable blocks on top of the platform such as lanterns, torches, carpets, flowers, crops, redstone components.
  4. Spawn a creeper or place a tnt on top of the center block
  5. Light the creeper/tnt with a flint and steel
  6. The attachable blocks will drop, but also regenerate after a few seconds.
    Screenshot:
    image

What is the expected output?

The blocks do not both drop AND regenerate

Towny version

Towny Version: 0.100.0.0

Server version

Paper version git-Paper-365 (MC: 1.20.4)

Please use Pastebin.com to link the following files

  1. Your full server startup from the logs\latest.log: latest.log
  2. Your Towny config.yml: config.yml
  3. Your townyperms.yml: townyperms.yml
  4. Your log's error: N/A
@blockutis blockutis added the bug label Jan 1, 2024
@Warriorrrr
Copy link
Member

Is there any block that should be protected but isn't? otherwise this is just a duplicate of #5689

@LlmDl
Copy link
Member

LlmDl commented Jan 3, 2024

@Warriorrrr I have been seeking better instructions on how to make it happen as I could not reproduce any duping on my test server, so I couldn't really begin to solve it.

LlmDl added a commit that referenced this issue Jan 8, 2024
@LlmDl
Working implementation preventing the drops that spawn from problem
1bce909 
blocks.

Many attachable blocks are not given the Attachable interface, making
that basically useless.

Instead an ItemLists was made up to keep the explodable attachables in
check during the ProtectionRegenTasks, which now takes special care to
nuke these blocks into Air.

Bonus: Adds ability to add ItemLists to ItemLists.

Closes #7154
Closes #5689
@LlmDl LlmDl self-assigned this Jan 8, 2024
@LlmDl LlmDl added the Completed label Jan 8, 2024
@LlmDl LlmDl added this to the 0.100.1.0 milestone Jan 8, 2024
@LlmDl LlmDl mentioned this issue Jan 8, 2024
Merged
1 task
LlmDl added a commit that referenced this issue Jan 8, 2024
@LlmDl
Prevent the drops that spawn from problem blocks which can be duped i…
be2ce23 
…n explosion regenerations. (#7176)

* Working implementation preventing the drops that spawn from problem
blocks.

Many attachable blocks are not given the Attachable interface, making
that basically useless.

Instead an ItemLists was made up to keep the explodable attachables in
check during the ProtectionRegenTasks, which now takes special care to
nuke these blocks into Air.

Bonus: Adds ability to add ItemLists to ItemLists.

Closes #7154
Closes #5689

* Handle doors special case.
LlmDl added a commit that referenced this issue Jan 8, 2024
@LlmDl
- Prevent the drops that spawn from problem blocks which can be duped
1bc2d6a 
in explosion regenerations.
    - These were things like carpets, pressureplates and other blocks
that attach to blocks.
    - Closes #7154, #5689.
  - Add claiming particle effect.
  - New Config Option: claiming.show_claiming_particles
    - Default: true
    - When false players will not see the particle flood effect when
they claim townblocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LlmDl LlmDl

Labels
bug Completed
Projects
None yet
Milestone
0.100.1.0
3 participants
@LlmDl @Warriorrrr @blockutis