Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed delete edge rule path value to string for guid #135

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

ToshY
Copy link
Owner

@ToshY ToshY commented Aug 31, 2024

Fixes #134

@ToshY
Copy link
Owner Author

ToshY commented Aug 31, 2024

Works now. Documentation already correct.


When testing noticed that the addOrUpdateEdgeRule both handles add and update and has several required keys set, but the majority of those are only relevant for adding a new rule. Updating a rule only seems to require the Guid and atleast 1 Triggers (else it results in {"ErrorKey":"edgerule.invalid","Field":"EdgeRule","Message":"At least one condition is required"}).

So need to create follow-up enhancement for that.

@ToshY ToshY merged commit 81d19df into master Aug 31, 2024
15 checks passed
@ToshY ToshY deleted the bug/134 branch August 31, 2024 18:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: API call to delete a Edge Rule for a given Pull Zone sends the wrong data for the edge rule
1 participant