Merge pull request #132 from ShellAddicted/v8HandleReplace

fix for Electron v5+
TooTallNate · May 7, 2019 · 0511f01 · 0511f01
2 parents f365fc8 + d202f84
commit 0511f01
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/binding.cc b/src/binding.cc
@@ -108,7 +108,11 @@ NAN_METHOD(Close) {
   info.GetReturnValue().Set(scope.Escape(Nan::New<v8::Integer>(r)));
 }
 
-void Initialize(Handle<Object> target) {
+/*
+<<in 2014, the V8 team deprecated v8::Handle in favor of v8::Local>>
+src: https://electronjs.org/blog/nodejs-native-addons-and-electron-5
+*/
+void Initialize(Local<Object> target) {
   Nan::HandleScope scope;
   Nan::ForceSet(target,
                 Nan::New("api_version").ToLocalChecked(),