Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node pre gyp path to search #32

Closed
wants to merge 3 commits into from

Conversation

bwknight877
Copy link

This change adds the default node-pre-gyp module_path to search like how sqlite3 does their native node module (and others too I'm sure)

This will search in ./lib/binding/{node_abi}-{platform}-{arch}

It looks like this also addresses Issue 11

Also it looked like there is a missing right paren, fixed that

Bryan Knight added 3 commits March 2, 2017 14:03
The node-pre-gyp docs have the binary go into `./lib/binding/{node_abi}-{platform}-{arch}`
@bwknight877
Copy link
Author

In an effort to make libxmljs use the ./lib/binding/{node_abi}-{platform}-{arch} directory for its native node module, I opened this PR to add this path to the default search paths for node-bindings

libxmljs PR 459 for reference
they were using node-bindings to load xmljs.node from ./build/Release/

@TooTallNate
Copy link
Owner

Thanks Bryan, merged this in 68dae57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants