Skip to content

fix: solving block ssl in validate token#799

Merged
TomerFi merged 5 commits into
TomerFi:devfrom
YogevBokobza:fix-validate-token
Aug 28, 2024
Merged

fix: solving block ssl in validate token#799
TomerFi merged 5 commits into
TomerFi:devfrom
YogevBokobza:fix-validate-token

Conversation

@YogevBokobza
Copy link
Copy Markdown
Collaborator

@YogevBokobza YogevBokobza commented Aug 13, 2024

Description

Describe what you did and why.

Related issue (if any): fixes #issue_number_goes_here

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

Anything else?

@pull-request-size pull-request-size Bot added the size: xs Pull request has less then 10 lines label Aug 13, 2024
@YogevBokobza
Copy link
Copy Markdown
Collaborator Author

This meant to fix this

@YogevBokobza YogevBokobza marked this pull request as ready for review August 13, 2024 22:28
@auto-me-bot auto-me-bot Bot added the status: needs review Pull request needs a review label Aug 13, 2024
@YogevBokobza
Copy link
Copy Markdown
Collaborator Author

I tested and looks like it's working.

TomerFi
TomerFi previously approved these changes Aug 13, 2024
@auto-me-bot auto-me-bot Bot added status: approved Pull request is approved and removed status: needs review Pull request needs a review labels Aug 13, 2024
@TomerFi
Copy link
Copy Markdown
Owner

TomerFi commented Aug 13, 2024

LGTM
Waiting for @thecode to have a look.

@YogevBokobza
Copy link
Copy Markdown
Collaborator Author

YogevBokobza commented Aug 25, 2024

@thecode I would be happy if you could review it please.
Thanks.

Comment thread src/aioswitcher/device/tools.py Outdated
@auto-me-bot auto-me-bot Bot added status: changes requested Pull request changes requested status: approved Pull request is approved and removed status: approved Pull request is approved status: changes requested Pull request changes requested labels Aug 25, 2024
@auto-me-bot auto-me-bot Bot added status: review started Pull review in progress and removed status: approved Pull request is approved labels Aug 26, 2024
@auto-me-bot auto-me-bot Bot added status: approved Pull request is approved and removed status: review started Pull review in progress labels Aug 27, 2024
@YogevBokobza
Copy link
Copy Markdown
Collaborator Author

@TomerFi Please approve and merge :)

@TomerFi TomerFi merged commit 6b80d03 into TomerFi:dev Aug 28, 2024
@auto-me-bot auto-me-bot Bot added status: merged Pull request merged and removed status: approved Pull request is approved labels Aug 28, 2024
@TomerFi
Copy link
Copy Markdown
Owner

TomerFi commented Aug 28, 2024

@thecode @YogevBokobza Do we need to release?

@ybokobza
Copy link
Copy Markdown

@thecode @YogevBokobza Do we need to release?

Yes we need.. this is been used in HA. Thanks :)

@TomerFi
Copy link
Copy Markdown
Owner

TomerFi commented Aug 29, 2024

Release 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request has less then 10 lines status: merged Pull request merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants