fix: unpack FA4 auxiliary outputs - #36
Closed
TomerBN-Nvidia wants to merge 1 commit into
Closed
TomerBN-Nvidia wants to merge 1 commit into
TomerBN-Nvidia wants to merge 1 commit into
Conversation
Backport the FA4 return-contract update from upstream commit 7cd1d57 so the v0.25.1 wrapper accepts the four values returned by the packaged CuTe implementation. Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: tbarnatan <tbarnatan@nvidia.com>
Owner
Author
|
Closing because this was mistakenly targeted at the BTK image-preparation branch. Reopening the same minimal backport against the canonical custom release branch super_vl_rl_v0.25.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_flash_attn_fwd7cd1d57b749f/ PR [CI/Build][Docker] Bump nvidia-cutlass-dsl to 4.6.0 and drop packaging workarounds vllm-project/vllm#47442Failure
HSG job
5915987loaded all 63 checkpoint shards, then failed during RADIO vision-encoder warmup:The SQSH's packaged CuTe implementation returns
(out, lse, p, row_max)on this path. The failure occurs entirely in vLLM FA4 before entering FlashInfer.Duplicate check
No open PR matching this fix was found in this fork or upstream. Upstream already carries the fix as part of merged PR vllm-project#47442; this PR is the minimal backport to
tbn/super-vl-bf16-btk-prep.Tests
.venv/bin/python -m compileall -q vllm/vllm_flash_attn/flash_attn_interface.pygit diff --checkuv run --no-sync pre-commit run --files vllm/vllm_flash_attn/flash_attn_interface.py— all applicable hooks passed5916309: one 4xGB200 node, TP4+EP, same model and r7 SQSH with only--mm-encoder-attn-backend TORCH_SDPA; server started and 3/3 image requests returned HTTP 200. This confirms the failure is isolated to the FA4 multimodal-encoder path.A rebuilt SQSH should be validated on one GB200 node with TP4+EP and an image request using the default
FLASH_ATTNmultimodal encoder backend.AI assistance
OpenAI Codex assisted with root-cause analysis and preparing this one-line backport. A human reviewer should review and understand the changed line before merge.