Feature/ask before deleting not empty list #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good already, thanks for this. If you have the time, can you split the documentation into its own PR? Thanks! Edit: Ah, sorry, went through this one first and just saw that you did that already 👍🏼 |
RedX2501
force-pushed
the
feature/ask-before-deleting-not-empty-list
branch
2 times, most recently
from
1330532 to
168316b
Compare
TomBursch
requested changes
Dec 13, 2024
RedX2501
force-pushed
the
feature/ask-before-deleting-not-empty-list
branch
2 times, most recently
from
1332585 to
d7a4a06
Compare
TomBursch
approved these changes
Dec 13, 2024
TomBursch
force-pushed
the
feature/ask-before-deleting-not-empty-list
branch
from
d7a4a06 to
aa73c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will ask if it is ok to delete the list if it still has items.
The function as factored out so I can later use it in the shopping lists overview when deleting shopping lists from there.
Please let me know if that is fine or you'd like to have a component.
This PR is still a draft due to it's dependency on other PRs. I'd like to get your feedback early so I know if the style is good.