Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: A unique user agent for the app #514

Closed
DanteMS opened this issue Sep 22, 2024 · 2 comments · Fixed by #544
Closed

Feature request: A unique user agent for the app #514

DanteMS opened this issue Sep 22, 2024 · 2 comments · Fixed by #544
Labels
enhancement New feature or request

Comments

@DanteMS
Copy link
Contributor

DanteMS commented Sep 22, 2024 •
edited
Loading

What's the feature 🧐

A unique user agent for the app. For example, KitchenOwl-android/0.5.2. The user agent it uses for now is Dart/3.4 (dart:io).
A possible use case: on my server I'm using a user agent-based redirection, so users wouldn't have to remember which subdomain to use for which app.
@DanteMS DanteMS added the enhancement New feature or request label Sep 22, 2024
@TomBursch TomBursch moved this to Planned in KitchenOwl Project Oct 4, 2024
@TomBursch TomBursch mentioned this issue Nov 15, 2024
Merged
@TomBursch
Copy link
Owner

The new user agent will be, as you suggested, KitchenOwl-platform/version.

@TomBursch TomBursch linked a pull request Nov 15, 2024 that will close this issue
feat: Use cronet client on android (Support device certificates) #544
Merged
@github-project-automation github-project-automation bot moved this from Planned to Ready for Testing in KitchenOwl Project Nov 15, 2024
@TomBursch TomBursch mentioned this issue Nov 15, 2024
Draft
@DanteMS
Copy link
Contributor Author

DanteMS commented Dec 30, 2024

Thanks for implementing this!
However, some paths, like images, still have the old user agent:

"GET /api/upload/97660742-fa3d-4ca6-8d6c-ee76eafb534a.png HTTP/1.1" 304 0 "-" "Dart/3.6 (dart:io)"
"GET /socket.io/?EIO=4&transport=websocket HTTP/1.1" 101 145 "-" "Dart/3.6 (dart:io)"

TomBursch added a commit that referenced this issue Dec 31, 2024
@TomBursch
fix: User agent
6e83ec3 
Mentioned in #514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
KitchenOwl Project
Status: Ready for Testing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use cronet client on android (Support device certificates) TomBursch/kitchenowl
2 participants
@DanteMS @TomBursch