Switch over to using u64s in the state array#8
Merged
TomAFrench merged 17 commits intomasterfrom Dec 7, 2022
Merged
Conversation
TomAFrench
force-pushed
the
u64-refactor
branch
from
2819777 to
b8266b4
Compare
Owner
Author
|
Note this only currently builds when building from noir-lang/noir#437 otherwise the pseudo bitshifting in the pad function causes a stack overflow. |
Co-authored-by: vezenovm <mvezenov@gmail.com>
TomAFrench
force-pushed
the
u64-refactor
branch
from
13d28ed to
8970217
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty quick and dirty attempt at this refactoring which ends up simplifying a lot of the code (except the padding function).
In the process I noticed that we had the chi function implemented incorrectly so have fixed this.
Something I need to check more is that I'm correctly handling the endianness of the lanes correctly. It's going to be easier to rotate something in the wrong direction now.