Consolidate constants to a single file#3
Merged
TomAFrench merged 3 commits intomasterfrom Nov 9, 2022
Merged
Conversation
* master: fix: remove some usages of NUM_LANES which isn't supported feat: use constant for lengths of lane offset values refactor: use global values for array sizes
Owner
Author
|
Ouch. I feel that we may need a test framework in rust at this rate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefixing all the imported constants with
constants::is pretty ugly. I need to see if there's a less verbose way of handling this but it's not documented afaik.