Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do proper curl error checking for domain lookups #243

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix: Do proper curl error checking for domain lookups #243

merged 1 commit into from
Dec 22, 2023

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Dec 21, 2023 •
edited
Loading

This change is Reviewable

@JFreegman JFreegman added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Dec 21, 2023
@JFreegman JFreegman added this to the 0.13.1 milestone Dec 21, 2023
@JFreegman JFreegman force-pushed the curl_setopt_return_check branch from 4740a5b to 0daaa39 Compare December 21, 2023 23:43
@JFreegman JFreegman force-pushed the curl_setopt_return_check branch from 0daaa39 to c7d96d5 Compare December 22, 2023 00:38
@JFreegman JFreegman force-pushed the curl_setopt_return_check branch from c7d96d5 to 7470a9a Compare December 22, 2023 00:48
@JFreegman JFreegman merged commit 7470a9a into TokTok:master Dec 22, 2023
@JFreegman JFreegman deleted the curl_setopt_return_check branch December 22, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iphydf iphydf iphydf approved these changes

Assignees

@JFreegman JFreegman

Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Milestone
v0.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JFreegman @iphydf