Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add nodejs 20.x to the list of CI targets. #185

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore: Add nodejs 20.x to the list of CI targets. #185

merged 1 commit into from
Feb 27, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Feb 27, 2024 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the master milestone Feb 27, 2024
@iphydf iphydf requested a review from a team as a code owner February 27, 2024 11:29
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (f11cf79) to head (d4f7e1c).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files           8        8           
  Lines        1544     1544           
=======================================
  Hits         1023     1023           
  Misses        521      521

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robinlinden
robinlinden approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both nodejs 12 and 13 are EOL, so I guess we can drop them whenever we feel like it.

@toktok-releaser toktok-releaser merged commit d4f7e1c into TokTok:master Feb 27, 2024
15 checks passed
@iphydf iphydf deleted the node20 branch February 27, 2024 13:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

Assignees

@iphydf iphydf

Labels
None yet
Projects
None yet
Milestone
master
Development

Successfully merging this pull request may close these issues.
3 participants
@iphydf @robinlinden @toktok-releaser