Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Slight code improvements. #148

Merged
merged 1 commit into from
Feb 23, 2022
Merged

cleanup: Slight code improvements. #148

merged 1 commit into from
Feb 23, 2022

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Feb 23, 2022 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.0.9 milestone Feb 23, 2022
@auto-add-label auto-add-label bot added the enhancement New feature for the user, not a new feature for build script label Feb 23, 2022
@iphydf iphydf mentioned this pull request Feb 23, 2022
Merged
@iphydf iphydf force-pushed the constness branch 5 times, most recently from 8c58547 to fb835dc Compare February 23, 2022 19:40
JFreegman
JFreegman approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf force-pushed the constness branch 3 times, most recently from 290e941 to 5dca86f Compare February 23, 2022 21:14
@iphydf iphydf changed the title feat: Add check for locals that can be const. cleanup: Slight code improvements. Feb 23, 2022
@auto-add-label auto-add-label bot added cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. and removed enhancement New feature for the user, not a new feature for build script labels Feb 23, 2022
@toktok-releaser toktok-releaser merged commit a321eb8 into TokTok:master Feb 23, 2022
@iphydf iphydf temporarily deployed to tokstyle February 23, 2022 21:21 Inactive
@iphydf iphydf deleted the constness branch February 23, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFreegman JFreegman JFreegman approved these changes

Assignees

@iphydf iphydf

Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Milestone
v0.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@iphydf @JFreegman @toktok-releaser