refactor: Remove generic instances for Maybe and Either
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bjornbugge
changed the title
Maybe and EitherMaybe and Either
auto-add-label
bot
added
the
refactor
|
Just got bitten by this too. The default encoding for |
iphydf
approved these changes
Dec 16, 2021
Bump library version number to `0.1.0` and use new Stackage LTS snapshot.
This reverts commit 8d993fc. It breaks a test in hs-msgpack-binary.
iphydf
added a commit
to iphydf/hs-msgpack-binary
that referenced
this pull request
Dec 16, 2021
These were removed in TokTok/hs-msgpack-types#37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I need a particular encoding of
MaybeandEitherfor compatibility reasons it's quite a hurdle that there's already a derived encoding bundled with this library. This PR removes the TH-derived decoders forMaybeandEitherand leaves it to users to derive them themselves if they need them.This change is