Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erase template fields #45

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Erase template fields #45

merged 1 commit into from
Jan 6, 2017

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 4, 2017 •
edited
Loading

This change is Reviewable

@iphydf
Allow deleting .travis.yml fields used only in templates.
198650c 
E.g. the haskell template uses a `package` and `haskell` field, but they
are meaningless to travis. This lets templates mark certain fields as
local only and have them erased after template expansion.
@robinlinden
Copy link
Member

:lgtm_strong:

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf merged commit 198650c into TokTok:master Jan 6, 2017
@iphydf iphydf temporarily deployed to git-critique January 6, 2017 15:42 Inactive
@iphydf iphydf deleted the erase-template-fields branch February 5, 2022 22:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@robinlinden robinlinden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iphydf @robinlinden