Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes about group identity and AV #15

Merged
merged 5 commits into from
Aug 4, 2018
Merged

Conversation

envsh
Copy link

@envsh envsh commented Jun 19, 2018

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ iphydf
✅ envsh
❌ kitech
You have signed the CLA already but the status is still pending? Let us recheck it.

@iphydf
Copy link
Member

iphydf commented Jun 23, 2018

It failed to build: https://travis-ci.org/TokTok/go-toxcore-c/builds/394161119#L1075

maybe rebase?

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 2 files at r2, 2 of 3 files at r3, 3 of 3 files at r4.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r6, 2 of 3 files at r7, 3 of 3 files at r8.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained


toxav.go, line 318 at r8 (raw file):

}

func (this *Tox) AddAVGroupChat(cbfn cb_audio_ftype) uint32 {

This change needs an update to group_test.go.

@iphydf iphydf merged commit 5ab0076 into TokTok:master Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants