Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the bazel build as one of the PR blocking builds. #996

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jul 10, 2018

PR-blocking, not nightly, because the bazel build is the only one that performs a layering check.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jul 10, 2018
@iphydf iphydf force-pushed the bazel-build branch 6 times, most recently from d1a99cb to be2263a Compare July 10, 2018 16:31
@iphydf iphydf changed the title Add the bazel build as one of the nightly builds. Add the bazel build as one of the PR blocking builds. Jul 10, 2018
@iphydf iphydf force-pushed the bazel-build branch 2 times, most recently from 8b6a9bb to cd03a71 Compare July 10, 2018 16:40
Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@iphydf iphydf merged commit 0b7e29e into TokTok:master Jul 12, 2018
@iphydf iphydf deleted the bazel-build branch July 12, 2018 09:18
@iphydf iphydf modified the milestones: v0.2.x, v0.2.4 Jul 16, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants