Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another TCP_test upgrade #955

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Another TCP_test upgrade #955

merged 1 commit into from
Jun 28, 2018

Conversation

hugbubby
Copy link
Member

@hugbubby hugbubby commented Jun 27, 2018

Mostly documentation + comments. Some cases where code was removed
in exchange for more compact/less sprawly for loops. Introduced a
function that removed like 30 lines of repeated code.

Edit: I do not understand git and I do not understand why I am pring old commits.


This change is Reviewable

@iphydf
Copy link
Member

iphydf commented Jun 27, 2018

Review status: 0 of 1 LGTMs obtained


auto_tests/TCP_test.c, line 48 at r1 (raw file):

}

void do_TCP_server_delay(TCP_Server *tcp_s, int delay)

static void


auto_tests/TCP_test.c, line 479 at r1 (raw file):

    c_sleep(50);

    //The connection status should be unconfirmed here because we have finished

Space after //.


auto_tests/TCP_test.c, line 494 at r1 (raw file):

        ck_assert_msg(tcp_con_status(conn) == TCP_CLIENT_CONFIRMED, "Wrong connection status. Expected: %d, is: %d",
                      TCP_CLIENT_CONFIRMED,
                      tcp_con_status(conn));

This line can be combined with the previous one (remove one newline).


Comments from Reviewable

@hugbubby
Copy link
Member Author

Review status: 0 of 1 LGTMs obtained


auto_tests/TCP_test.c, line 48 at r1 (raw file):

Previously, iphydf wrote…

static void

Done.


auto_tests/TCP_test.c, line 479 at r1 (raw file):

Previously, iphydf wrote…

Space after //.

Keep forgetting that. Habit I guess.


auto_tests/TCP_test.c, line 494 at r1 (raw file):

Previously, iphydf wrote…

This line can be combined with the previous one (remove one newline).

Done.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Jun 28, 2018

:lgtm_strong:


Reviewed 1 of 1 files at r2.
Review status: :shipit: complete! 1 of 1 LGTMs obtained


Comments from Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jun 28, 2018
Mostly documentation + comments. Some cases where code was removed
in exchange for more compact/less sprawly for loops. Introduced a
function that removed like 30 lines of repeated code.
@iphydf iphydf merged commit 4e3bfac into TokTok:master Jun 28, 2018
@iphydf iphydf modified the milestones: v0.2.x, v0.2.4 Jul 16, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants