Clarify/Improve test_some test

[hugbubby]

Same thing as last time, another mild pull request as I go. A few better error messages, more logical sleep() call placements, comments, etc. For one of the test_basic functions I randomized the time between messages and the sizes in which portions of message are sent, for more coverage.

Did not modify large chunk of the test_some function because I didn't understand the second half of it. Maybe I'll come back later once I've figured out what it's doing.

---

This change is 

[iphydf]

Review status: 0 of 1 LGTMs obtained

---

auto_tests/TCP_test.c, line 110 at r1 (raw file):

                  "The attempt to send the last byte of handshake failed.");

    c_sleep(100);

Why 100?

---

auto_tests/TCP_test.c, line 118 at r1 (raw file):

    uint8_t response_plain[TCP_HANDSHAKE_PLAIN_SIZE];
    ck_assert_msg(net_recv(sock, response, TCP_SERVER_HANDSHAKE_SIZE) == TCP_SERVER_HANDSHAKE_SIZE,
                  "Could/Did not receive a server response to the initial handshake.");

nit: "did" lowercase.

---

auto_tests/TCP_test.c, line 140 at r1 (raw file):

    uint32_t i = 0;

    while (i < sizeof(r_req)) {

for (uint32_t i = 0; i < sizeof(r_req);) { ...

This limits the scope of i to the loop.

---

auto_tests/TCP_test.c, line 141 at r1 (raw file):

    while (i < sizeof(r_req)) {
        uint8_t msg_length = rand() % 5 + 1; // msg_length = 1-5

1-5 = -4. What you mean is: msg_length is between 1 and 5.

---

auto_tests/TCP_test.c, line 151 at r1 (raw file):

        i += msg_length;

        c_sleep(rand() % 10 + 45); // Wait 45-55 milliseconds

Why the random jitter?

---

auto_tests/TCP_test.c, line 155 at r1 (raw file):

    }

    // Receiving the second resonse and verifying its validity

"response"

---

auto_tests/TCP_test.c, line 173 at r1 (raw file):

    ck_assert_msg(public_key_cmp(packet_resp_plain + 2, f_public_key) == 0, "Server sent the wrong public key.");

    //Closing connections.

nit: space after //

---

auto_tests/TCP_test.c, line 316 at r1 (raw file):

    ck_assert_msg(public_key_cmp(data + 2, con1->public_key) == 0, "Key in response packet wrong.");

    uint8_t test_packet[512] = {16, 17, 16, 86, 99, 127, 255, 189, 78}; //What is this packet????

No idea :). @irungentoo: do you remember what this packet means?

---

Comments from Reviewable

[hugbubby]

Review status: 0 of 1 LGTMs obtained

---

auto_tests/TCP_test.c, line 110 at r1 (raw file):

Previously, iphydf wrote…

Why 100?

Old file did it with two calls and I just ended up merging them.

---

auto_tests/TCP_test.c, line 140 at r1 (raw file):

Previously, iphydf wrote…

for (uint32_t i = 0; i < sizeof(r_req);) { ...

This limits the scope of i to the loop.

Done.

---

auto_tests/TCP_test.c, line 141 at r1 (raw file):

Previously, iphydf wrote…

1-5 = -4. What you mean is: msg_length is between 1 and 5.

Done.

---

auto_tests/TCP_test.c, line 151 at r1 (raw file):

Previously, iphydf wrote…

Why the random jitter?

Idk, indecipherably useless idea to RANDOMIZE TIME BETWEEN SENDS

EXTRA DURABILITY

---

auto_tests/TCP_test.c, line 155 at r1 (raw file):

Previously, iphydf wrote…

"response"

Done.

---

auto_tests/TCP_test.c, line 316 at r1 (raw file):

Previously, iphydf wrote…

No idea :). @irungentoo: do you remember what this packet means?

Imagine being such a chad you directly read and write packets in raw uint8 arrays

---

Comments from Reviewable

[iphydf]

---

Reviewed 1 of 1 files at r2.
Review status: complete! 1 of 1 LGTMs obtained

---

Comments from Reviewable